[SPARK-12539][follow-up] always sort in partitioning writer#10638
Closed
cloud-fan wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-12539][follow-up] always sort in partitioning writer#10638cloud-fan wants to merge 2 commits intoapache:masterfrom
cloud-fan wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Test build #48926 has finished for PR 10638 at commit
|
Contributor
There was a problem hiding this comment.
Could we generate a partition key (excluding the sorting key)? we just need to compare the key
|
Test build #49001 has finished for PR 10638 at commit
|
cloud-fan
force-pushed
the
bucket-write
branch
from
cceb7a8 to
247ddad
Compare
|
Test build #49051 has finished for PR 10638 at commit
|
Contributor
|
LGTM. |
Contributor
|
I manually resolved the conflict during merging and merged it. Thanks. |
Contributor
|
@cloud-fan Should we create a patch for 1.6 branch? |
Contributor
Author
|
only backport it without bucket-write? |
Contributor
|
Yes, cc @marmbrus |
Contributor
|
We discussed this and decided not to do it, because this is a simple config change users can apply. Changing the behavior automatically for users in a point release is also bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address comments in #10498 , especially #10498 (comment)